Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add cleanup to users tests #30654

Merged
merged 4 commits into from
Oct 19, 2023
Merged

test: add cleanup to users tests #30654

merged 4 commits into from
Oct 19, 2023
+275 −247

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

with this changes the users API tests don't left any extra data on DB.. that means it can run indefinite times with .only and doesn't interfere with other tests.

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2ee3293

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #30654 (d7bc003) into develop (ab0c287) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30654      +/-   ##
===========================================
- Coverage    51.19%   51.03%   -0.16%     
===========================================
  Files          812      810       -2     
  Lines        15067    15162      +95     
  Branches      2751     2812      +61     
===========================================
+ Hits          7713     7738      +25     
- Misses        6944     6988      +44     
- Partials       410      436      +26
Flag Coverage Δ
e2e 48.35% <ø> (-0.14%) ⬇️
unit 64.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 17, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2023
View reviewed changes
apps/meteor/tests/end-to-end/api/01-users.js Dismissed Show dismissed Hide dismissed
@sampaiodiego sampaiodiego force-pushed the add-clean-test-api-users branch from 592ba44 to 48190c5 Compare October 17, 2023 14:13
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 17, 2023
@sampaiodiego sampaiodiego force-pushed the add-clean-test-api-users branch from 48190c5 to 2ee3293 Compare October 17, 2023 16:30
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 17, 2023
@sampaiodiego sampaiodiego marked this pull request as ready for review October 17, 2023 16:32
@sampaiodiego sampaiodiego requested a review from a team as a code owner October 17, 2023 16:32
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 19, 2023
@sampaiodiego sampaiodiego merged commit 79f6388 into develop Oct 19, 2023
42 of 43 checks passed
@sampaiodiego sampaiodiego deleted the add-clean-test-api-users branch October 19, 2023 19:57
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
@sampaiodiego @debdutdeb
test: add cleanup to users tests (#30654)
c2151e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevLehman KevLehman KevLehman approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampaiodiego @KevLehman